Skip to content

[material-ui] Support props callback type in theme variants #40946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZeeshanTamboli merged 5 commits into from
Mar 2, 2024
Merged

[material-ui] Support props callback type in theme variants #40946

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
be2d082
add failing test
ZeeshanTamboli Feb 5, 2024
1e209b5
add callback types
ZeeshanTamboli Feb 5, 2024
df3d540
rerun CI
ZeeshanTamboli Feb 5, 2024
af168d1
add ownerState in parameter type
ZeeshanTamboli Mar 2, 2024
5c773ad
Merge branch 'master' into fix-40671-variants-callback-typescript
ZeeshanTamboli Mar 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
add failing test
  • Loading branch information
@ZeeshanTamboli
ZeeshanTamboli committed Feb 5, 2024
commit be2d0822712cb2f6b2f6348c415b50418fddcd5a
18 changes: 18 additions & 0 deletions packages/mui-material/src/styles/createTheme.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,24 @@ const theme = createTheme();
});
}

// props callback in variants
{
createTheme({
components: {
MuiButton: {
variants: [
{
props: (props) => props.color !== 'secondary',
style: ({ theme: { palette } }) => ({
backgroundColor: palette.grey[500],
}),
},
],
},
},
});
}

{
createTheme({
shape: {
Expand Down