Skip to content

Conversation

@mnajdova
Copy link
Member

@mnajdova mnajdova commented May 24, 2024

Fixes #41753

Codesandbox with the fix

@mnajdova mnajdova added type: bug It doesn't behave as expected. scope: slider Changes related to the slider. needs cherry-pick The PR should be cherry-picked to master after merge. labels May 24, 2024
@mui-bot
Copy link

mui-bot commented May 24, 2024

Netlify deploy preview

https://deploy-preview-42370--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against c5d9797

@mnajdova mnajdova marked this pull request as ready for review May 24, 2024 09:20
@mnajdova mnajdova requested a review from ZeeshanTamboli May 24, 2024 09:20
@ZeeshanTamboli ZeeshanTamboli changed the title [Slider] Fix wrong CSS value [material-ui][Slider] Fix wrong CSS value May 24, 2024
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! I also spent few hours on it but couldn't find a solution. 😅 The CodeSandbox you posted doesn't show the fix. Here's the one that does: https://codesandbox.io/p/sandbox/hardcore-napier-3gzxhk.

@mnajdova
Copy link
Member Author

mnajdova commented May 24, 2024

The CodeSandbox you posted doesn't show the fix. Here's the one that does: https://codesandbox.io/p/sandbox/hardcore-napier-3gzxhk.

Aaah, I didn't save the changes, I've udpated the PR description.

@aaronlademann-wf
Copy link
Contributor

@mnajdova any chance a5c5ca9 could be cherry picked into a patch on the 5.x line of release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs cherry-pick The PR should be cherry-picked to master after merge. scope: slider Changes related to the slider. type: bug It doesn't behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[material-ui][Slider][CssVarsProvider] Custom SliderThumb with CssVarsProvider is broken after upgrade @mui/material to 5.15.14

4 participants