Skip to content

Allow Plot.label to control title(s) #2934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mwaskom merged 8 commits into from
Aug 4, 2022
Merged

Allow Plot.label to control title(s) #2934

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f954124
Don't show facet variable names in facet titles
mwaskom Aug 1, 2022
3cf0437
Don't document Plot.label as accepting None as a value
mwaskom Aug 1, 2022
27aaf09
Allow Plot.label to control titles, including when faceting
mwaskom Aug 2, 2022
82eefe0
Don't include separator in labeled facet title
mwaskom Aug 2, 2022
4acc646
Clean up title typing
mwaskom Aug 3, 2022
8817e8f
Fix legend test
mwaskom Aug 3, 2022
2ff3e20
Fix legend contents typing after rebase
mwaskom Aug 4, 2022
1562c2f
Add theme update to Plot.clone and remove outdated todo
mwaskom Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add theme update to Plot.clone and remove outdated todo
  • Loading branch information
@mwaskom
mwaskom committed Aug 4, 2022
commit 1562c2f7701f90935d73ed27c841906a59f17029
6 changes: 3 additions & 3 deletions seaborn/_core/plot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,7 @@ def __init__(
raise TypeError(err)

self._data = PlotData(data, variables)

self._layers = []

self._scales = {}
Expand Down Expand Up @@ -249,8 +250,9 @@ def _clone(self) -> Plot:
new._layers.extend(self._layers)

new._scales.update(self._scales)
new._labels.update(self._labels)
new._limits.update(self._limits)
new._labels.update(self._labels)
new._theme.update(self._theme)

new._facet_spec.update(self._facet_spec)
new._pair_spec.update(self._pair_spec)
Expand Down Expand Up @@ -616,8 +618,6 @@ def label(self, *, title=None, **variables: str | Callable[[str], str]) -> Plot:
When using a single subplot, `title=` sets its title.

"""
# TODO should col=... add a "label" to the facet titles?
# How does this interact with title=...?
new = self._clone()
if title is not None:
new._labels["title"] = title
Expand Down