Skip to content

Allow Plot.label to control title(s) #2934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mwaskom merged 8 commits into from
Aug 4, 2022
Merged

Allow Plot.label to control title(s) #2934

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f954124
Don't show facet variable names in facet titles
mwaskom Aug 1, 2022
3cf0437
Don't document Plot.label as accepting None as a value
mwaskom Aug 1, 2022
27aaf09
Allow Plot.label to control titles, including when faceting
mwaskom Aug 2, 2022
82eefe0
Don't include separator in labeled facet title
mwaskom Aug 2, 2022
4acc646
Clean up title typing
mwaskom Aug 3, 2022
8817e8f
Fix legend test
mwaskom Aug 3, 2022
2ff3e20
Fix legend contents typing after rebase
mwaskom Aug 4, 2022
1562c2f
Add theme update to Plot.clone and remove outdated todo
mwaskom Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix legend test
  • Loading branch information
@mwaskom
mwaskom committed Aug 4, 2022
commit 8817e8f488fcc7389b5b4b72fb84c0af7a4fc1b5
2 changes: 1 addition & 1 deletion tests/_core/test_plot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1791,7 +1791,7 @@ def test_single_layer_common_unnamed_variable(self, xy):

labels = list(np.unique(s)) # assumes sorted order

assert e[0] == (None, id(s))
assert e[0] == ("", id(s))
assert e[-1] == labels

artists = e[1]
Expand Down