Skip to content

fix(iroh): always ping new paths, add test for reconnecting with changed addrs #3372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(iroh): always ping new paths, add test for reconnecting with changed addrs #3372

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
14c6d1d
tests(iroh): add test to reconnect after forceful abort
Frando Jun 27, 2025
9866f0e
tests: simplify abort-and-reconnect test
Frando Jun 27, 2025
087f003
fix(iroh): always ping new paths
Frando Jun 27, 2025
a00644a
tests: improve reconnect test
Frando Jun 27, 2025
a8ee257
fix(iroh): when ports change for the current best address, use it
Frando Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(iroh): always ping new paths
  • Loading branch information
@Frando
Frando committed Jun 27, 2025
commit 087f003b5f486697fe0b3c3ca6bcd9cbd350f50e
7 changes: 4 additions & 3 deletions iroh/src/magicsock/node_map/node_state.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -789,12 +789,13 @@ impl NodeState {
self.prune_direct_addresses();
}

// if the endpoint does not yet have a best_addrr
// if the endpoint does not yet have a best_addr, or if this is a new path
let needs_ping_back = if matches!(path, SendAddr::Udp(_))
&& matches!(
&& (matches!(
self.udp_paths.best_addr.state(now),
best_addr::State::Empty | best_addr::State::Outdated(_)
) {
) || matches!(role, PingRole::NewPath))
{
// We also need to send a ping to make this path available to us as well. This
// is always sent together with a pong. So in the worst case the pong gets lost
// and this ping does not. In that case we ping-pong until both sides have
Expand Down
Loading