ci: Improve e2e test timings #23159
Merged
ci: Improve e2e test timings #23159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BundleMonFiles added (2)
Total files change +255.73KB Groups added (2)
Final result: ✅ View report in BundleMon website ➡️ |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
2 issues found across 5 files
Prompt for AI agents (all 2 issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name=".github/scripts/docker/docker-config.mjs">
<violation number="1" location=".github/scripts/docker/docker-config.mjs:34">
P1: Removing `push_to_ghcr = false` changes PR behavior: builds will now push to GHCR (default is `true`). If this is intentional, the change should be documented. If not, add `context.push_to_ghcr = false;` to preserve the original behavior.</violation>
</file>
<file name=".github/workflows/playwright-test-ci.yml">
<violation number="1" location=".github/workflows/playwright-test-ci.yml:31">
P1: Missing `docker-image` parameter: The workflow receives `docker_image` input but doesn't pass it to the reusable workflow. With `test-mode: docker-pull`, the tests will pull `n8nio/n8n:nightly` (default) instead of the pre-built PR image, defeating the purpose of the docker-build-pr job.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
shortstacked
force-pushed
the
CAT-1920
branch
from
b9963e2 to
4b044f0
Compare
This comment has been minimized.
This comment has been minimized.
|
E2E Tests: n8n tests passed after 7m 20.1s Run Details
Groups
This message was posted automatically by
currents.dev | Integration Settings
|
4 tasks
shortstacked
force-pushed
the
CAT-1920
branch
2 times, most recently
from
f7b523d to
516bccd
Compare
…way-to-run-e2e-tests-less-frequently-while-keeping
shortstacked
force-pushed
the
CAT-1920
branch
from
516bccd to
2da4b46
Compare
shortstacked
force-pushed
the
CAT-1920
branch
from
c2a4333 to
5bc41ce
Compare
shortstacked
force-pushed
the
CAT-1920
branch
from
5bc41ce to
11f7e0c
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…a-way-to-run-e2e-tests-less-frequently-while-keeping
shortstacked
force-pushed
the
CAT-1920
branch
from
c041cc0 to
55db1d9
Compare
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
seemewalkin
reviewed
Dec 15, 2025
seemewalkin
reviewed
Dec 15, 2025
Comment on lines
+87
to
+89
| # docker-build: build app + docker image locally | ||
| # docker-pull: no build needed, image is pre-built | ||
| # local: build app for local server |
seemewalkin
reviewed
Dec 15, 2025
|
|
||
| on: | ||
| pull_request: | ||
| merge_group: |
Contributor
|
✅ No visual regressions found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
E2E tests will run less frequently due to increased stability of CI overall. Less retries = less executions
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/CAT-1920/ci-find-a-way-to-run-e2e-tests-less-frequently-while-keeping-ci-time
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)