-
Notifications
You must be signed in to change notification settings - Fork 52.4k
ci: Improve e2e test timings #23159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
ci: Improve e2e test timings #23159
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
fd7745f
ci: Change e2e to pull prebuilt docker image
shortstacked 2da4b46
Merge remote-tracking branch 'origin/master' into cat-1920-ci-find-a-…
shortstacked 11f7e0c
ci: Consolidate composite actions
shortstacked 1a25f06
ci: Small tweaks
shortstacked 3444b7e
ci: Final cleanup
shortstacked 6e38310
Merge branch 'master' into CAT-1920
shortstacked 558003b
ci: Improve cancelling in progress
shortstacked 98f0901
Merge branch 'master' into CAT-1920
shortstacked 09f06ef
Merge branch 'master' into CAT-1920
shortstacked e4a7ac1
ci: Cleanup of Playwright turbo tasks
shortstacked b13c892
ci: Go back to local build mode
shortstacked fefaedc
ci: Change e2e to pull prebuilt docker image
shortstacked a444bef
ci: Consolidate composite actions
shortstacked 7c79e10
ci: Small tweaks
shortstacked 0938262
ci: Final cleanup
shortstacked 6a0ff9e
ci: Improve cancelling in progress
shortstacked c3a40af
ci: Cleanup of Playwright turbo tasks
shortstacked ce9e449
ci: Go back to local build mode
shortstacked ed33ac6
ci: Optional skip licenses
shortstacked 55db1d9
Merge remote-tracking branch 'origin/CAT-1920' into cat-1920-ci-find-…
shortstacked 85777ff
Merge branch 'master' into CAT-1920
shortstacked 854dc1f
ci: Fix cache inconsistency
shortstacked dc4d4d3
Merge branch 'master' into CAT-1920
shortstacked File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,9 +2,10 @@ name: Build, unit test and lint branch | |
|
|
||
| on: | ||
| pull_request: | ||
| merge_group: | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🙌 |
||
|
|
||
| concurrency: | ||
| group: ci-${{ github.event.pull_request.number || github.ref }} | ||
| group: ci-${{ github.event.pull_request.number || github.event.merge_group.head_sha || github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| env: | ||
|
|
@@ -19,10 +20,16 @@ jobs: | |
| outputs: | ||
| frontend_changed: ${{ steps.paths-filter.outputs.frontend == 'true' }} | ||
| non_python_changed: ${{ steps.paths-filter.outputs.non-python == 'true' }} | ||
| commit_sha: ${{ steps.commit-sha.outputs.sha }} | ||
| steps: | ||
| - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| with: | ||
| ref: refs/pull/${{ github.event.pull_request.number }}/merge | ||
| # Use merge_group SHA when in merge queue, otherwise PR merge ref | ||
| ref: ${{ github.event_name == 'merge_group' && github.event.merge_group.head_sha || format('refs/pull/{0}/merge', github.event.pull_request.number) }} | ||
|
|
||
| - name: Capture commit SHA for cache consistency | ||
| id: commit-sha | ||
| run: echo "sha=$(git rev-parse HEAD)" >> "$GITHUB_OUTPUT" | ||
|
|
||
| - name: Check for frontend changes | ||
| uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2 | ||
|
|
@@ -41,7 +48,7 @@ jobs: | |
| - '!packages/@n8n/task-runner-python/**' | ||
| - name: Setup and Build | ||
| if: steps.paths-filter.outputs.non-python == 'true' | ||
| uses: n8n-io/n8n/.github/actions/setup-nodejs-blacksmith@f5fbbbe0a28a886451c886cac6b49192a39b0eea # v1.104.1 | ||
| uses: ./.github/actions/setup-nodejs | ||
|
|
||
| - name: Run format check | ||
| if: steps.paths-filter.outputs.non-python == 'true' | ||
|
|
@@ -63,16 +70,16 @@ jobs: | |
| steps: | ||
| - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| with: | ||
| ref: refs/pull/${{ github.event.pull_request.number }}/merge | ||
| ref: ${{ needs.install-and-build.outputs.commit_sha }} | ||
|
|
||
| - name: Setup pnpm CLI | ||
| uses: pnpm/action-setup@a7487c7e89a18df4991f7f222e4898a00d66ddda # v4.1.0 | ||
| uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 # v4.2.0 | ||
|
|
||
| - name: Setup Node.js | ||
| uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0 | ||
| uses: actions/setup-node@395ad3262231945c25e8478fd5baf05154b1d79f # v6.1.0 | ||
| with: | ||
| node-version: '22.x' | ||
| cache: pnpm | ||
| cache: 'pnpm' | ||
|
|
||
| - name: Install dependencies | ||
| run: pnpm install --frozen-lockfile | ||
|
|
@@ -92,7 +99,7 @@ jobs: | |
| uses: ./.github/workflows/units-tests-reusable.yml | ||
| needs: install-and-build | ||
| with: | ||
| ref: refs/pull/${{ github.event.pull_request.number }}/merge | ||
| ref: ${{ needs.install-and-build.outputs.commit_sha }} | ||
| collectCoverage: true | ||
| secrets: | ||
| CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} | ||
|
|
@@ -105,10 +112,10 @@ jobs: | |
| steps: | ||
| - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| with: | ||
| ref: refs/pull/${{ github.event.pull_request.number }}/merge | ||
| ref: ${{ needs.install-and-build.outputs.commit_sha }} | ||
|
|
||
| - name: Setup Node.js | ||
| uses: n8n-io/n8n/.github/actions/setup-nodejs-blacksmith@f5fbbbe0a28a886451c886cac6b49192a39b0eea # v1.104.1 | ||
| uses: ./.github/actions/setup-nodejs | ||
| with: | ||
| build-command: pnpm typecheck | ||
|
|
||
|
|
@@ -118,13 +125,15 @@ jobs: | |
| uses: ./.github/workflows/linting-reusable.yml | ||
| needs: install-and-build | ||
| with: | ||
| ref: refs/pull/${{ github.event.pull_request.number }}/merge | ||
| ref: ${{ needs.install-and-build.outputs.commit_sha }} | ||
|
|
||
| e2e-tests: | ||
| name: E2E Tests | ||
| needs: [install-and-build] | ||
| needs: install-and-build | ||
| if: needs.install-and-build.outputs.non_python_changed == 'true' | ||
| uses: ./.github/workflows/playwright-test-ci.yml | ||
| with: | ||
| branch: ${{ needs.install-and-build.outputs.commit_sha }} | ||
| secrets: inherit | ||
|
|
||
| # This job is required by GitHub branch protection rules. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.