chore(core): Set foreign key constraint on ChatHub agentId #23275
Conversation
autologie
changed the title
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
E2E Tests: n8n tests passed after 7m 35.6s Run Details
Groups
This message was posted automatically by
currents.dev | Integration Settings
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 5 files
Prompt for AI agents (all 1 issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/@n8n/db/src/migrations/common/1765886667897-AddAgentIdForeignKeys.ts">
<violation number="1" location="packages/@n8n/db/src/migrations/common/1765886667897-AddAgentIdForeignKeys.ts:13">
P1: Hardcoded double-quote column escaping (`"agentId"`) will fail on MySQL/MariaDB. Use `escape.columnName('agentId')` to ensure cross-database compatibility.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
packages/@n8n/db/src/migrations/common/1765886667897-AddAgentIdForeignKeys.ts
Outdated
Show resolved
Hide resolved
| 'agentId', | ||
| [table.agents, 'id'], | ||
| 'FK_chat_hub_sessions_agentId', | ||
| 'SET NULL', |
There was a problem hiding this comment.
Why not cascade delete ? Is there a possibility that the agent is deleted and we should still keep the messages ?
There was a problem hiding this comment.
I think we want to keep sessions and messages, as these are historical data to browse even when the user doesn't need the agent anymore for new conversations.
There was a problem hiding this comment.
Yeah, seems better & more intuitive than deletion
guillaumejacquart
left a comment
guillaumejacquart
left a comment
There was a problem hiding this comment.
looks good to me
|
Got released with |
Summary
This PR follows up #23032 to introduce foreign key constraint on
agentIdcolumn in the ChatHub session and message table.Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)