-
Notifications
You must be signed in to change notification settings - Fork 89
Add RequestTimeout option to NatsJSOpts for request operations #918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
sign-off check isn't working because when checked out I can't see the signature 😕 .. even though github seems to be happy saying it's 'verified'. as long as github is happy we're fine. we can ignore the failing action. |
mtmk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @johnweldon
(minor nit above)
Strange: It's signed with an SSH key |
ah, so that's your local git log I presume. When I clone I see I must be doing something wrong verifying SSH signatures. edit: my bad. didn't have |
|
ah, yes. it was a problem with the sign-off check workflow. thanks for the fix @johnweldon! |
…ection NatsOpts value
The previous implementation used the defaults from the connections NatsOpts RequestTimeout for JetStream specific request/reply operations.
This change allows setting a separate default value for JetStream operations from the core NatsOpts default.