Skip to content

Fix pull request exception handling #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mtmk merged 1 commit into from
Jul 31, 2025
Merged

Fix pull request exception handling #919

mtmk merged 1 commit into from
Jul 31, 2025

Conversation

@mtmk
Copy link
Member

@mtmk mtmk commented Jul 29, 2025 •
edited
Loading

The idea is to avoid exceptions killing the pull loop and rely on timeouts to retry the pull in worst case scenario.

@mtmk mtmk mentioned this pull request Jul 29, 2025
Closed
@mtmk mtmk requested a review from scottf July 31, 2025 07:15
scottf
scottf approved these changes Jul 31, 2025
View reviewed changes
Copy link
Contributor

@scottf scottf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtmk mtmk merged commit 0d77cc4 into main Jul 31, 2025
22 checks passed
@mtmk mtmk deleted the fix-consumer-pull-loop-error-handling branch July 31, 2025 15:31
mtmk added a commit that referenced this pull request Aug 1, 2025
@mtmk
Release 2.6.6
e4b3742 
* Add watcher cancellation handling (#881)
* Fix pull request exception handling (#919)
* Add RequestTimeout option to NatsJSOpts for request operations (#918)
@mtmk mtmk mentioned this pull request Aug 1, 2025
Merged
mtmk added a commit that referenced this pull request Aug 1, 2025
@mtmk
Release 2.6.6 (#923)
0f79f61 
* Add watcher cancellation handling (#881)
* Fix pull request exception handling (#919)
* Add RequestTimeout option to NatsJSOpts for request operations (#918)
This was referenced Aug 4, 2025
Open
Merged
@mtmk mtmk mentioned this pull request Sep 22, 2025
Merged
This was referenced Nov 3, 2025
Closed
Merged
@dependabot dependabot bot mentioned this pull request Dec 1, 2025
Merged
@dependabot dependabot bot mentioned this pull request Dec 22, 2025
Closed
@dependabot dependabot bot mentioned this pull request Jan 12, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scottf scottf scottf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Broken PullLoop inside NatsJsConsume in case of an exception at CallNextMsgAsync

3 participants

@mtmk @scottf