Skip to content

Fix pull request exception handling #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtmk merged 1 commit into from
Jul 31, 2025
Merged

Fix pull request exception handling #919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/NATS.Client.JetStream/Internal/NatsJSConsume.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,20 @@ private async Task PullLoop()
await foreach (var pr in _pullRequests.Reader.ReadAllAsync().ConfigureAwait(false))
{
var origin = $"pull-loop({pr.Origin})";
await CallMsgNextAsync(origin, pr.Request).ConfigureAwait(false);
try
{
await CallMsgNextAsync(origin, pr.Request).ConfigureAwait(false);
}
catch (Exception e)
{
if (_debug)
{
_logger.LogDebug(NatsJSLogEvents.PullRequest, e, "Error during pull request issued for {Origin} {Batch}, {MaxBytes}", origin, pr.Request.Batch, pr.Request.MaxBytes);
}

continue;
}

if (_debug)
{
_logger.LogDebug(NatsJSLogEvents.PullRequest, "Pull request issued for {Origin} {Batch}, {MaxBytes}", origin, pr.Request.Batch, pr.Request.MaxBytes);
Expand Down
15 changes: 14 additions & 1 deletion src/NATS.Client.JetStream/Internal/NatsJSOrderedConsume.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,20 @@ private async Task PullLoop()
await foreach (var pr in _pullRequests.Reader.ReadAllAsync().ConfigureAwait(false))
{
var origin = $"pull-loop({pr.Origin})";
await CallMsgNextAsync(origin, pr.Request).ConfigureAwait(false);
try
{
await CallMsgNextAsync(origin, pr.Request).ConfigureAwait(false);
}
catch (Exception e)
{
if (_debug)
{
_logger.LogDebug(NatsJSLogEvents.PullRequest, e, "Error during pull request issued for {Origin} {Batch}, {MaxBytes}", origin, pr.Request.Batch, pr.Request.MaxBytes);
}

continue;
}

if (_debug)
{
_logger.LogDebug(NatsJSLogEvents.PullRequest, "Pull request issued for {Origin} {Batch}, {MaxBytes}", origin, pr.Request.Batch, pr.Request.MaxBytes);
Expand Down
Loading