Skip to content

feat: cjs, es & umd bundles for graphql-hooks-memcache #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jackdclark merged 2 commits into from
Mar 7, 2019
Merged

feat: cjs, es & umd bundles for graphql-hooks-memcache #109

jackdclark merged 2 commits into from
Mar 7, 2019

Conversation

@jackdclark
Copy link
Contributor

@jackdclark jackdclark commented Mar 7, 2019

What does this PR do?

  • Creates a shared rollup config at the root
  • Moves rollup & related dependencies to root
  • Adds a rollup config, build & prepublish steps for graphql-hooks-memcache

Related issues

Closes #95

Checklist

  • I have checked the contributing document
  • I have added or updated any relevant documentation
  • I have added or updated any relevant tests

@jackdclark jackdclark requested review from Joezo and bmullan91 March 7, 2019 11:15
Joezo
Joezo reviewed Mar 7, 2019
View reviewed changes
packages/graphql-hooks-memcache/package.json Outdated
"files": [
"dist",
"es",
"lib"
Copy link
Contributor

@Joezo Joezo Mar 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should publish the src folder to npm too. It can be useful to devs when debugging. Thoughts? @jackdclark @bmullan91

Copy link
Contributor Author

@jackdclark jackdclark Mar 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, can do 👍

Copy link
Contributor

@bmullan91 bmullan91 Mar 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

bmullan91
bmullan91 approved these changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@bmullan91 bmullan91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

packages/graphql-hooks-memcache/package.json Outdated
"files": [
"dist",
"es",
"lib"
Copy link
Contributor

@bmullan91 bmullan91 Mar 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@jackdclark jackdclark mentioned this pull request Mar 7, 2019
Merged
3 tasks
@jackdclark jackdclark merged commit 9dd1004 into master Mar 7, 2019
@jackdclark jackdclark deleted the feat/rollup-memcache branch March 7, 2019 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Joezo Joezo Joezo left review comments

@bmullan91 bmullan91 bmullan91 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jackdclark @bmullan91 @Joezo