Integration tests & bug fixes #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
bmullan91
commented
Feb 26, 2019
bmullan91
force-pushed
the
useClientRequest_bug_integration_tests
branch
from
2045254 to
be0ddc0
Compare
jackdclark
reviewed
Feb 26, 2019
jackdclark
previously approved these changes
Feb 26, 2019
jackdclark
approved these changes
Feb 26, 2019
Contributor
Author
|
@all-contributors please add @bmullan91 for test |
Contributor
|
I've put up a pull request to add @bmullan91! 🎉 |
3 tasks
Joezo
added a commit
that referenced
this pull request
Feb 28, 2019
### What does this PR do? After updating the next.js example with the latest release we noticed that all our data would disappear when fetching more results. The way we recommend to do that is by updating the variables passed into `useQuery` and supplying an `updateData` method, which is responsible for merging the previous and new results. We previously merged a fix (#61) that resets state if variables or query changes in `useClientRequest`. The fix in this is to only reset the state if `updateData` is not set. This means that `state.data` is always populated after the initial request in this scenario. ### Checklist - [x] I have checked the [contributing document](../blob/master/CONTRIBUTING.md) - [x] I have added or updated any relevant documentation - [x] I have added or updated any relevant tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes bugs (listed below) and also introduces integration tests.
Related issues
Checklist