Skip to content

Integration tests & bug fixes #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmullan91 merged 10 commits into from
Feb 27, 2019
Merged

Integration tests & bug fixes #61

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8af656a
failing test for options change no resending query
bmullan91 Feb 26, 2019
a8035e6
fixes #60
bmullan91 Feb 26, 2019
aa66aa5
integration tests
bmullan91 Feb 26, 2019
ac74879
fixes #37
bmullan91 Feb 26, 2019
be0ddc0
re-add react-testing-library as a dev-dep
bmullan91 Feb 26, 2019
b6fcd3d
testHook -> renderHook
bmullan91 Feb 26, 2019
8e9beb5
re-add cleanup afterEach setup
bmullan91 Feb 26, 2019
7d42227
use beforeEach + jest.fn in integration tests
bmullan91 Feb 26, 2019
d8d1817
add test for SSR cacheHit render count
bmullan91 Feb 26, 2019
2519897
use allOpts in useEffect check
bmullan91 Feb 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
use allOpts in useEffect check
  • Loading branch information
@bmullan91
bmullan91 committed Feb 26, 2019
commit 2519897ca8e02665d311ae38a996eee1f91ef528
2 changes: 1 addition & 1 deletion src/useQuery.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ module.exports = function useQuery(query, opts = {}) {

React.useEffect(() => {
queryReq();
}, [query, JSON.stringify(opts)]);
}, [query, JSON.stringify(allOpts)]);

return {
...state,
Expand Down