Create 0034-find-first-and-last-position-of-element-in-sorted-array.js #2620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solved find-first-and-last-position-of-element-in-sorted-array in js.
aakhtar3
requested changes
Jun 30, 2023
| if(target < nums[mid]) { | ||
| right = mid-1; | ||
| } | ||
| // this is the meat of the code |
There was a problem hiding this comment.
Suggestion: Remove comment and creat descriptive variables or functions
const isTarget = (...);
if (isTarget) { ... }| result.push(binarySearch(true)); | ||
| result.push(binarySearch(false)); | ||
|
|
||
| function binarySearch(leftBias) { |
There was a problem hiding this comment.
Suggestion: name booleans that prompt a question
isLeftBiasThere was a problem hiding this comment.
Just a kind reminder that I updated the code as suggested.
Making variable names more descriptive.
aakhtar3
requested changes
Jul 20, 2023
| result.push(binarySearch(true)); | ||
| result.push(binarySearch(false)); | ||
|
|
||
| function binarySearch(isLeftBias) { |
aakhtar3
requested changes
Jul 20, 2023
|
|
||
| while(left <= right) { | ||
|
|
||
| const mid = Math.floor((left+right)/2); |
Using the bitwise operator and removing the inner function.
aakhtar3
approved these changes
Jul 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved find-first-and-last-position-of-element-in-sorted-array in js.
File(s) Added: 0034-find-first-and-last-position-of-element-in-sorted-array.js
Language(s) Used: JavaScript
Submission URL: https://leetcode.com/problems/find-first-and-last-position-of-element-in-sorted-array/submissions/985379429/