Skip to content

Create 0034-find-first-and-last-position-of-element-in-sorted-array.js #2620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 22, 2023
Merged

Create 0034-find-first-and-last-position-of-element-in-sorted-array.js #2620

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5020e65
Create 0034-find-first-and-last-position-of-element-in-sorted-array.js
aadil42 Jun 22, 2023
b44ad16
Update 0034-find-first-and-last-position-of-element-in-sorted-array.js
aadil42 Jul 3, 2023
fe9c706
Update 0034-find-first-and-last-position-of-element-in-sorted-array.js
aadil42 Jul 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update 0034-find-first-and-last-position-of-element-in-sorted-array.js 
Making variable names more descriptive.
  • Loading branch information
@aadil42
aadil42 authored Jul 3, 2023
commit b44ad1666937ca3a6e1acc53c46c4dd8fd109d47
9 changes: 5 additions & 4 deletions javascript/0034-find-first-and-last-position-of-element-in-sorted-array.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ var searchRange = function(nums, target) {
result.push(binarySearch(true));
result.push(binarySearch(false));

function binarySearch(leftBias) {
function binarySearch(isLeftBias) {
Copy link
Collaborator

@aakhtar3 aakhtar3 Jul 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid nested functions

Copy link
Contributor Author

@aadil42 aadil42 Jul 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

let left = 0;
let right = nums.length - 1;
let index = -1;
Expand All @@ -28,9 +28,10 @@ var searchRange = function(nums, target) {
if(target < nums[mid]) {
right = mid-1;
}
// this is the meat of the code
if(target === nums[mid]) {
if(leftBias) {

const isTarget = target === nums[mid];
if(isTarget) {
if(isLeftBias) {
index = mid;
right = mid - 1;
} else {
Expand Down