Skip to content

Conversation

@hahuja2
Copy link
Contributor

@hahuja2 hahuja2 commented Oct 13, 2025

This PR ensures idle laravel queue workers are properly handled by ending the current transaction and starting a new one.

@hahuja2 hahuja2 marked this pull request as ready for review October 13, 2025 20:46
@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented Oct 13, 2025

Test Suite Status Result
Multiverse 13/16 passing
SOAK 87/89 passing

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2025

Codecov Report

❌ Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.43%. Comparing base (be8c5c1) to head (17cf177).
⚠️ Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
agent/fw_laravel.c 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1126      +/-   ##
==========================================
- Coverage   78.44%   78.43%   -0.02%     
==========================================
  Files         193      193              
  Lines       28059    28064       +5     
==========================================
+ Hits        22012    22013       +1     
- Misses       6047     6051       +4     
Flag Coverage Δ
agent-for-php-7.2 78.39% <0.00%> (-0.02%) ⬇️
agent-for-php-7.3 78.41% <0.00%> (-0.02%) ⬇️
agent-for-php-7.4 78.27% <0.00%> (-0.02%) ⬇️
agent-for-php-8.0 77.79% <20.00%> (-0.02%) ⬇️
agent-for-php-8.1 78.10% <20.00%> (-0.02%) ⬇️
agent-for-php-8.2 77.71% <20.00%> (-0.02%) ⬇️
agent-for-php-8.3 77.71% <20.00%> (-0.02%) ⬇️
agent-for-php-8.4 77.73% <20.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hahuja2 hahuja2 force-pushed the laravel_queue_fix_idle_issue branch from 51d9264 to ca310f5 Compare October 15, 2025 16:43
@hahuja2 hahuja2 requested review from lavarou and zsistla October 20, 2025 19:46
@lavarou lavarou changed the title chore(agent): properly handle idle laravel queue workers feat(agent): properly handle idle laravel queue workers Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants