Skip to content

feat(agent): properly handle idle laravel queue workers #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 6, 2025
Merged

feat(agent): properly handle idle laravel queue workers #1126

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b37a77f
feat(agent): end transaction for laravel horizon
hahuja2 Sep 23, 2025
30c3589
chore(agent): change function location to inside of conditional
hahuja2 Sep 24, 2025
6ad9417
testing
hahuja2 Oct 9, 2025
6071735
chore(agent): end transaction when queue worker is idling
hahuja2 Oct 10, 2025
a990a2c
chore(agent): add verbosedebug
hahuja2 Oct 13, 2025
d82aef1
chore(agent): add verbosedebug
hahuja2 Oct 13, 2025
d570c32
chore(agent): add verbosedebug
hahuja2 Oct 13, 2025
64ac4f7
chore(agent): remove verbosedebug
hahuja2 Oct 13, 2025
ca310f5
chore(agent): add comment
hahuja2 Oct 13, 2025
17cf177
chore(agent): change wrapper name
hahuja2 Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions agent/fw_laravel.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1208,6 +1208,19 @@ NR_PHP_WRAPPER(nr_laravel_horizon_end_txn) {
}
NR_PHP_WRAPPER_END

/*
* End transaction for idle laravel queue workers and then start
* a new transaction.
*/
NR_PHP_WRAPPER(nr_laravel_queue_restart_transaction) {
NR_UNUSED_SPECIALFN;
(void)wraprec;

nr_php_txn_end(1, 0 TSRMLS_CC);
nr_php_txn_begin(NULL, NULL TSRMLS_CC);
}
NR_PHP_WRAPPER_END

void nr_laravel_enable(TSRMLS_D) {
/*
* We set the path to 'unknown' to prevent having to name routing errors.
Expand Down Expand Up @@ -1259,6 +1272,15 @@ void nr_laravel_enable(TSRMLS_D) {
nr_php_wrap_user_function_before_after_clean(
NR_PSTR("Laravel\\Horizon\\Console\\SupervisorCommand::handle"),
nr_laravel_horizon_end_txn, NULL, NULL);

/*
* The following function has been added to ensure idle laravel queue workers
* are properly handled by ending the current transaction and starting a new
* one.
*/
nr_php_wrap_user_function_before_after_clean(
NR_PSTR("Illuminate\\Queue\\Worker::daemonShouldRun"),
nr_laravel_queue_restart_transaction, NULL, NULL);
#else
nr_php_wrap_user_function(NR_PSTR("Symfony\\Component\\Console\\Application::doRun"),
nr_laravel_console_application_dorun TSRMLS_CC);
Expand Down