chore: Removed package-lock.json #2208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsumners-nr
commented
May 22, 2024
| run: | | ||
| # Install deps in caller repo | ||
| npm ci | ||
| npm install |
Contributor
Author
There was a problem hiding this comment.
The only concern I have in this PR is this line. I do not expect any problem as npm install should still install all dependencies. The difference would be if a repo that is reusing this workflow has updates to package.json and not package-lock.json. In that case, npm ci would notice the discrepancy and generate an error. Whereas npm install will install the dependencies as noted by package.json.
bizob2828
requested changes
May 23, 2024
Member
bizob2828
left a comment
bizob2828
left a comment
There was a problem hiding this comment.
I think we should add package-lock.json to .gitignore to be safe. I know you set it in npmignore but wouldn't hurt.
Contributor
Author
Good call. Done. |
bizob2828
approved these changes
May 23, 2024
This was referenced Jul 20, 2024
This was referenced Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we discussed prior to stand-up on 2024-05-22, this PR removes the
package-lock.jsonfrom this repo. Doing so provides:npm install newrelic, the lock file does not get consulted and thus none of the Dependabot changes have any affect on our customers.package.jsonso that test suites can be triggered or skipped accordingly. With the lock file in place, this sort of workflow detection will be very difficult.