-
Notifications
You must be signed in to change notification settings - Fork 423
feat: Updated opentelemetry bridge to rely on configuration based transformation rules #3125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Updated opentelemetry bridge to rely on configuration based transformation rules #3125
Conversation
…o do rpc client and fallback
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3125 +/- ##
==========================================
- Coverage 97.64% 97.58% -0.07%
==========================================
Files 336 332 -4
Lines 50601 50289 -312
==========================================
- Hits 49409 49073 -336
- Misses 1192 1216 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| if (this.#reconciler.isHostnameKey(key) === true) { | ||
| value = this.#reconciler.resolveHost(value) | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intention of the reconciler was to expose a simple interface for reconciling attributes. To that end, the isHostnameKey and resolveHost were private methods used internally. It seems that they have been exposed for this singular conditional.
Do we need to refactor the reconciler to handle this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to refactor the transformation rules to just run as mappers within the reconciler but it got very messy. So now it processes the attributes defined in transformation rules and assigns them as skip in the reconciler. I also see an issue with the required keys as new conventions are released a key may not be in the array to format the hostname accordingly. I'm open to ideas but that's why I exposed this on the reconciler
Description
This PR attempts to remove all static logic around synthesis of segments, transactions and time slice metrics. The intention is long term we would not keep a copy of rules in our agent but instead consume on connect.
Related Issues
Closes #3092