chore: finished fixing tests

newrelic · bizob2828 · Jun 2, 2025 · May 14, 2025 · May 15, 2025 · May 16, 2025
commit ae9ef174766d240d755cfad28784eebc35e1f19c
diff --git a/lib/otel/rules.js b/lib/otel/rules.js
@@ -77,10 +77,7 @@ class Rule {
   }
 
   get type() {
-    if (this.#type) {
-      return this.#type
-    }
-    return this.isServerRule ? 'server' : 'client'
+    return this.#type
   }
 
   get attributes() {

diff --git a/lib/otel/segments/database.js b/lib/otel/segments/database.js
@@ -43,6 +43,11 @@ module.exports = function createDbSegment(agent, otelSpan, rule) {
     ;[operation] = operation.split(' ')
     name = transformTemplate(segmentTransformation.name.template, { type: system, operation })
     recorder = getRecorder({ operation: true, system })
+  // fallback to just use system as name
+  } else {
+    const parsedStatement = new ParsedStatement(system)
+    name = transformTemplate(segmentTransformation.name.template, parsedStatement)
+    recorder = getRecorder({ operation: false, parsed: parsedStatement, system })
   }
 
   const segment = agent.tracer.createSegment({

diff --git a/lib/otel/segments/utils.js b/lib/otel/segments/utils.js
@@ -45,10 +45,10 @@ function transformTemplate(template, data, rules = {}) {
       if (key in rules) {
         return rules[key](data[key])
       } else {
-        return data[key]
+        return data[key] ?? 'unknown'
       }
     } else {
-      return ''
+      return 'unknown'
     }
   })
 }

diff --git a/test/unit/lib/otel/attr-mapping/db.test.js b/test/unit/lib/otel/attr-mapping/db.test.js
diff --git a/test/unit/lib/otel/attr-mapping/faas.test.js b/test/unit/lib/otel/attr-mapping/faas.test.js
diff --git a/test/unit/lib/otel/attr-mapping/http.test.js b/test/unit/lib/otel/attr-mapping/http.test.js