Increase toast z-index above modal dialogs #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vincent Petry <[email protected]>
12 tasks
ChristophWurst
approved these changes
Nov 12, 2020
delete-merged-branch
bot
deleted the
bugfix/noid/increase-toast-zindex
branch
Contributor
|
@PVince81 you forgot to update the changelog https://github.com/nextcloud/nextcloud-dialogs/blob/master/CHANGELOG.md Only @nc/vue doesn't have it (maybe we should), I think Chrisoph's libraries uses them and Christoph prefers to have it via the Changelog instead of the release list 😉 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because our modals are on 1000 and we want to see the toast notifications higher: https://github.com/nextcloud/nextcloud-vue/blob/master/src/components/Modal/Modal.vue#L496