fix overlapping menu #423
fix overlapping menu #423
Conversation
Signed-off-by: szaimen <[email protected]>
szaimen
requested review from
GretaD,
PVince81,
jancborchardt and
nimishavijay
| margin-top: 45px; | ||
| position: fixed; | ||
| z-index: 10100; | ||
| z-index: 2000; // Needs to be below Nextcloud menu entries see https://github.com/nextcloud/server/issues/26518 |
There was a problem hiding this comment.
This will cause a regression with modals as the 10100 value was introduced in #236 to fix that
There was a problem hiding this comment.
for which modals would this apply?
There was a problem hiding this comment.
Any modal from the vue library for example: viewer, firstrunwizard, settings dialogs
There was a problem hiding this comment.
So in this case do you see a way to fix this nextcloud/server#26518 at all?
There was a problem hiding this comment.
maybe can we move the toasts a bit to the left? so that it doesn't overlap anymore with the menu?
There was a problem hiding this comment.
So in this case do you see a way to fix this nextcloud/server#26518 at all?
Can't think of a proper way currently. The issue is that the modal should overlap all content (also the header menus) while the toast should still be overlapped by the menus.
maybe can we move the toasts a bit to the left? so that it doesn't overlap anymore with the menu?
Also not a solution as the menu has a dynamic width depending on the translations and the same issue also exists for the other popovers like search.
There was a problem hiding this comment.
@juliushaertl Is there maybe a way to have the z-index for the dialogs by default on 2000 and simply increase it to 10100 when the modal opens and reset it again when it gets closed?
There was a problem hiding this comment.
Is there maybe a way to have the z-index for the dialogs by default on 2000 and simply increase it to 10100 when the modal opens and reset it again when it gets closed?
Not sure how that would solve anything. Notifications e.g. is a popup just like in the screenshot, but the toasts triggered from it should overlap the popup. So the library can not solve this. In the case above we should:
- Make sure the quota error is only shown once
- The user should use the close button to navigate to the menu.
|
Design-wise it looks good! But yeah, Julius’ feedback is valid :) |
|
What is the status here? |
It can be closed as this is not fixable here. |
|
Thanks for the update @szaimen :) |
Fix nextcloud/server#26518
Signed-off-by: szaimen [email protected]