Remove sidebar actions slot max height

[marcoambrosini]

Needed to fit talk's description in the header slot.

Signed-off-by: Marco Ambrosini [email protected]

[skjnldsv]

Maybe we should even rename the slot :p

[marcoambrosini]

How would you like it named?? :)

[skjnldsv]

How would you like it named?? :)

No clue, could be description. I am not the best to find names 🙈

[skjnldsv]

In that case, since we're at it with the breaking changes, rename secondary-actions to actions ? As well as tertiary-actions to star ? 🤔 🤷

cc @raimund-schluessler

[marcoambrosini]

I just wanted to remove a css rule though 😅

[raimund-schluessler]

I just wanted to remove a css rule though 😅

Would this be a breaking change as well?

Renaming these slots requires every app using the appsidebar to adjust (I don't mind though, I don't use it yet, just thinking loud 🙈)

As well as tertiary-actions to star ?

It's only a star by default, but since it's a slot, it can be anything. So star might be to specific as a slot name.

[marcoambrosini]

I'm fine with anything here, just lmk what to do :)

[skjnldsv]

Would this be a breaking change as well?

There is another pr that touches the sidebar that is breaking change yes :)

[skjnldsv]

It's only a star by default, but since it's a slot, it can be anything. So star might be to specific as a slot name.

I would argue that 'tertiary-actions' isn't really self-explanatory either 😛

[marcoambrosini]

So should I do this?? #1566 (review)

[marcoambrosini]

I got back to renaming only the slot and classes referring to that slot because of naming conflicts. Let's address the rest of the names in separate PRs if needed.