Adapt files and app settings to @nc/vue changes #26196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-nc
added
bug
3. to review
Member
Author
|
/compile amend / |
npmbuildbot-nextcloud
bot
force-pushed
the
fix/app-sidebar-description-slot
branch
from
e3a2e6c to
9d1d95e
Compare
marcoambrosini
approved these changes
Mar 18, 2021
PVince81
added
4. to release
Member
|
/compile amend / |
rullzer
force-pushed
the
fix/app-sidebar-description-slot
branch
from
9d1d95e to
3c172ce
Compare
Member
|
Removed the extra settings files |
…me 'description' in @nc/vue v3.3.0 Signed-off-by: Julien Veyssier <[email protected]> Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AppSidebar
primary-actionsslot becamedescriptionin @nc/vue v3.3.0 (nextcloud-libraries/nextcloud-vue#1566).This PR adapts the slot name in templates when this component is used in app settings and in files.
I've noticed it's also used in Calendar app but @nc/vue is still v2.9.0 there.
Let's keep that in mind in case @nc/vue version is bumped in
stable21😁.