Skip to content

Actions - small a11y adjusts #2848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusknorr merged 1 commit into from
Jul 16, 2022
Merged

Actions - small a11y adjusts #2848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/ActionButton/ActionButton.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,11 @@ export default {
</docs>

<template>
<li class="action" :class="{ 'action--disabled': disabled }">
<li class="action" role="presentation" :class="{ 'action--disabled': disabled }">
<button class="action-button"
:class="{ focusable: isFocusable }"
:aria-label="ariaLabel"
role="menuitem"
type="button"
@click="onClick">
<!-- @slot Manually provide icon -->
Expand Down
5 changes: 3 additions & 2 deletions src/components/Actions/Actions.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ export default {
<div v-else
v-show="hasMultipleActions || forceMenu"
:class="{'action-item--open': opened}"

class="action-item">
<!-- If more than one action, create a popovermenu -->
<Popover :delay="0"
Expand All @@ -186,7 +187,7 @@ export default {
'action-item__menutoggle--default-icon': !iconSlotIsPopulated && defaultIcon === '',
'action-item__menutoggle--primary': primary
}"
aria-haspopup="true"
aria-haspopup="menu"
:aria-label="ariaLabel"
:aria-controls="randomId"
:aria-expanded="opened ? 'true' : 'false'"
Expand All @@ -213,7 +214,7 @@ export default {
@keydown.esc.exact.prevent="closeMenu"
@mousemove="onMouseFocusAction">
<!-- menu content -->
<ul :id="randomId" tabindex="-1">
<ul :id="randomId" tabindex="-1" role="menu">
<template v-if="opened">
<slot />
</template>
Expand Down