Skip to content

Actions - small a11y adjusts #2848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
juliusknorr merged 1 commit into from
Jul 16, 2022
Merged

Actions - small a11y adjusts #2848

juliusknorr merged 1 commit into from
Jul 16, 2022

Conversation

@vinicius73
Copy link
Contributor

@vinicius73 vinicius73 commented Jul 15, 2022

#2502 add role=menu to Actions
c5bbe7e 
add role="presentation" and role="menuitem" ActionButton

Signed-off-by: Vinicius Reis <[email protected]>
@vinicius73 vinicius73 added 3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Jul 15, 2022
@vinicius73 vinicius73 changed the title #2502 Small a11y adjusts Small a11y adjusts Jul 15, 2022
@vinicius73 vinicius73 changed the title Small a11y adjusts Actions - small a11y adjusts Jul 15, 2022
@juliusknorr juliusknorr merged commit 24b0837 into master Jul 16, 2022
@juliusknorr juliusknorr deleted the 2502-actionmenu-accessibility branch July 16, 2022 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

+1 more reviewer

@Pytal Pytal Pytal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vinicius73 @juliusknorr @Pytal