Skip to content

Rework the modal sizes and layout #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 2 commits into from
Mar 20, 2019
Merged

Rework the modal sizes and layout #312

skjnldsv merged 2 commits into from
Mar 20, 2019

Conversation

@skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Mar 20, 2019

  • Put the arrows to flex next to the container so we can have an adaptive positioning
  • Reworked the layout of the full size so that the arrows are absolute and over the container

Layouts:

Normal Capture d’écran_2019-03-20_10-33-10
Large Capture d’écran_2019-03-20_10-34-08
Full (mobile mode) Capture d’écran_2019-03-20_10-34-55

@skjnldsv skjnldsv added 3. to review Waiting for reviews high High priority design Design, UX, interface and interaction design feature: modal Related to the modal component labels Mar 20, 2019
@skjnldsv skjnldsv self-assigned this Mar 20, 2019
@skjnldsv
Rework the modal sizes and layout
9631ebc 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv mentioned this pull request Mar 20, 2019
Merged
1 task
@skjnldsv
Add spread navigation prop
c53fce8 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
ChristophWurst
ChristophWurst approved these changes Mar 20, 2019
View reviewed changes
Copy link
Contributor

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, screenshots as well

@skjnldsv skjnldsv merged commit d8d026e into master Mar 20, 2019
@skjnldsv skjnldsv deleted the fix/modal/sizes branch March 20, 2019 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@skjnldsv skjnldsv

Labels

3. to review Waiting for reviews design Design, UX, interface and interaction design feature: modal Related to the modal component high High priority

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@skjnldsv @ChristophWurst