Skip to content

use nextcloud-vue's modal #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 2 commits into from
Mar 20, 2019
Merged

use nextcloud-vue's modal #178

MorrisJobke merged 2 commits into from
Mar 20, 2019

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Mar 20, 2019 •
edited
Loading

@skjnldsv
use nextcloud-vue's modal
8d42451 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv added this to the Nextcloud 16 milestone Mar 20, 2019
@skjnldsv skjnldsv self-assigned this Mar 20, 2019
@skjnldsv skjnldsv requested a review from juliusknorr March 20, 2019 10:19
@skjnldsv skjnldsv mentioned this pull request Mar 20, 2019
Closed
MorrisJobke
MorrisJobke approved these changes Mar 20, 2019
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@skjnldsv
Bump nextcloud-vue to 0.9.3 & build
3f529c2 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv
Copy link
Member Author

skjnldsv commented Mar 20, 2019

Rebuild and ready to merge

@MorrisJobke MorrisJobke merged commit 750b896 into master Mar 20, 2019
@MorrisJobke MorrisJobke deleted the enhancement/modal/use-nextcloud-vue branch March 20, 2019 15:44
@MorrisJobke MorrisJobke mentioned this pull request Mar 21, 2019
Merged
9 tasks
@juliusknorr juliusknorr mentioned this pull request Mar 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@skjnldsv skjnldsv

Labels

3. to review design

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

3 participants

@skjnldsv @MorrisJobke