Skip to content

Add title prop to components for native tooltips #3569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JuliaKirschenheuter merged 1 commit into from
Dec 22, 2022
Merged

Add title prop to components for native tooltips #3569

JuliaKirschenheuter merged 1 commit into from
Dec 22, 2022

Conversation

@JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Dec 13, 2022 •
edited
Loading

Add title prop to components for native tooltips which are used in files_sharing app.

Fixes nextcloud/server#35857
Fixes nextcloud/server#35858
Fixes nextcloud/server#35860
Fixes nextcloud/server#35862

@JuliaKirschenheuter JuliaKirschenheuter added the 2. developing Work in progress label Dec 13, 2022
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Dec 13, 2022
@JuliaKirschenheuter JuliaKirschenheuter changed the title Adapt avatar and NcButton to correct showing of native tooltip Adapt several NC Vue components for work with custom tooltips Dec 13, 2022
@JuliaKirschenheuter JuliaKirschenheuter marked this pull request as ready for review December 21, 2022 07:26
@JuliaKirschenheuter JuliaKirschenheuter added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 21, 2022
@ChristophWurst
Copy link
Contributor

ChristophWurst commented Dec 21, 2022

Resolves #3550

The ticket mentions five components, this PR touches two. Please clarify.

@ChristophWurst ChristophWurst changed the title Adapt several NC Vue components for work with custom tooltips Add title prop to avatar and button components Dec 21, 2022
@ChristophWurst
Copy link
Contributor

ChristophWurst commented Dec 21, 2022

Title adjusted to reflect the actual changes.

@ChristophWurst ChristophWurst added enhancement New feature or request feature: avatar Related to the avatar component feature: button accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Dec 21, 2022
PVince81
PVince81 reviewed Dec 21, 2022
View reviewed changes
st3iny
st3iny reviewed Dec 21, 2022
View reviewed changes
Copy link
Contributor

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. What about the other 2 components (ref what Christoph asked)?

@JuliaKirschenheuter
Copy link
Contributor Author

JuliaKirschenheuter commented Dec 21, 2022 •
edited
Loading

The ticket mentions five components, this PR touches two. Please clarify.

Adapted NcAppSidebar and NcButton, thanks. Other components won't be used for files && files_sharing. I will create other PR for other componets at the right time.

@JuliaKirschenheuter JuliaKirschenheuter changed the title Add title prop to avatar and button components Add title prop to components for native tooltips Dec 21, 2022
@ChristophWurst
Copy link
Contributor

ChristophWurst commented Dec 21, 2022

Could you please create it now?

The title of this PR is once again misleading if you are saying that the title prop change is only partially done with your changes.

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the enh/3550-Adapt_several_NC_Vue_components_for_work_with_custom_tooltips branch from de723b5 to b089386 Compare December 22, 2022 11:40
@JuliaKirschenheuter JuliaKirschenheuter mentioned this pull request Dec 22, 2022
Merged
8 tasks
@JuliaKirschenheuter
Copy link
Contributor Author

JuliaKirschenheuter commented Dec 22, 2022

Code looks good. What about the other 2 components (ref what Christoph asked)?

I've changed a description of this PR. Could you please review again?

@JuliaKirschenheuter JuliaKirschenheuter merged commit 0976fad into master Dec 22, 2022
@JuliaKirschenheuter JuliaKirschenheuter deleted the enh/3550-Adapt_several_NC_Vue_components_for_work_with_custom_tooltips branch December 22, 2022 13:22
@jotoeri jotoeri added this to the 7.3.0 milestone Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@GretaD GretaD Awaiting requested review from GretaD

@PVince81 PVince81 Awaiting requested review from PVince81

@st3iny st3iny Awaiting requested review from st3iny

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels

3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities enhancement New feature or request feature: avatar Related to the avatar component feature: button

Projects

None yet

Milestone

7.3.0

7 participants

@JuliaKirschenheuter @ChristophWurst @PVince81 @st3iny @marcoambrosini @jotoeri