Skip to content

Replace custom tooltips with native one in vue components and views #35655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JuliaKirschenheuter merged 1 commit into from
Jan 9, 2023
Merged

Replace custom tooltips with native one in vue components and views #35655

JuliaKirschenheuter merged 1 commit into from
Jan 9, 2023

Conversation

@JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Dec 7, 2022 •
edited by AndyScherzinger
Loading

Fixes #35654

Before example:

Screenshot from 2022-12-08 13-46-45

Screenshot from 2022-12-09 11-37-19

After example:

Screenshot from 2022-12-09 09-24-32
Screenshot from 2022-12-09 09-24-55

Screenshot from 2022-12-09 11-38-06

Summary

  • Replace custom tooltips with native one in vue components and views
  • Fix bug with wrong appearing notifications by setting password
  • Add aria-label as same as tooltip message

Checklist

@JuliaKirschenheuter JuliaKirschenheuter added the 2. developing Work in progress label Dec 7, 2022
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Dec 7, 2022
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the enh/35654-Replace_custom_tooltips_with_native_one_for_files_sharing branch from c80375e to 83a7f48 Compare December 9, 2022 10:33
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the enh/35654-Replace_custom_tooltips_with_native_one_for_files_sharing branch from 83a7f48 to 0a2a386 Compare December 13, 2022 10:53
@JuliaKirschenheuter JuliaKirschenheuter marked this pull request as ready for review December 13, 2022 10:53
@JuliaKirschenheuter JuliaKirschenheuter added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 13, 2022
ChristophWurst
ChristophWurst reviewed Dec 13, 2022
View reviewed changes
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the enh/35654-Replace_custom_tooltips_with_native_one_for_files_sharing branch from 0a2a386 to 656ca59 Compare December 14, 2022 12:08
@JuliaKirschenheuter
Copy link
Contributor Author

JuliaKirschenheuter commented Dec 14, 2022

/backport to stable25

Pytal
Pytal approved these changes Dec 14, 2022
View reviewed changes
@JuliaKirschenheuter JuliaKirschenheuter removed the request for review from nimishavijay December 15, 2022 15:24
@nimishavijay nimishavijay mentioned this pull request Dec 15, 2022
Open
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the enh/35654-Replace_custom_tooltips_with_native_one_for_files_sharing branch from d93160d to 595820a Compare December 21, 2022 07:44
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the enh/35654-Replace_custom_tooltips_with_native_one_for_files_sharing branch from 595820a to 00ee2a1 Compare December 21, 2022 15:38
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the enh/35654-Replace_custom_tooltips_with_native_one_for_files_sharing branch from 00ee2a1 to 2d7da0d Compare December 22, 2022 08:57
@JuliaKirschenheuter
Copy link
Contributor Author

JuliaKirschenheuter commented Dec 22, 2022

I think we can merge this PR even if it needs a release of NC Vue. Changes from nextcloud-libraries/nextcloud-vue#3569 are relevant for correct showing of native tooltips but also causes no errors without released NC Vue. I've put a checkbox #35654 (comment) and will reopen this issue as far this PR got merged.

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Dec 23, 2022

vue component has been released with fix, v.7.3.0

@PVince81
Copy link
Member

PVince81 commented Jan 4, 2023 •
edited
Loading

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 4, 2023
@PVince81 PVince81 force-pushed the enh/35654-Replace_custom_tooltips_with_native_one_for_files_sharing branch from 2d7da0d to 1063fbc Compare January 5, 2023 07:58
@PVince81
Copy link
Member

PVince81 commented Jan 5, 2023

rebased and recompiled

@JuliaKirschenheuter JuliaKirschenheuter merged commit 3892c3e into master Jan 9, 2023
@JuliaKirschenheuter JuliaKirschenheuter deleted the enh/35654-Replace_custom_tooltips_with_native_one_for_files_sharing branch January 9, 2023 10:21
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 9, 2023
Merged
1 task
@solracsf solracsf mentioned this pull request May 9, 2023
Closed
5 tasks
@solracsf
Copy link
Member

solracsf commented May 17, 2023

FYI this caused a regression affecting master and all versions (v26, v25): #38157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@Pytal Pytal Pytal approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@st3iny st3iny Awaiting requested review from st3iny

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BITV]: Replace custom tooltips with native one for files_sharing

7 participants

@JuliaKirschenheuter @AndyScherzinger @PVince81 @solracsf @ChristophWurst @Pytal