Add info NoteCard #4063
Add info NoteCard #4063
Conversation
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
Thanks for your PR! I think it should work with the changes below.
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
Clicked the wrong button, see the feedback above
|
Nice! Thank you for the contribution :) Could you please share a screenshot for easy design review by anyone else also? :) |
There was a problem hiding this comment.
Works and looks good. Thanks a lot! :)
I took the liberty to add it to the examples.
@moan0s for us being able to merge this, can you please fix DCO? See https://github.com/nextcloud/nextcloud-vue/pull/4063/checks?check_run_id=13318409670 for details
|
Oh yes, sorry I forgot that and did not check the CI. Should be fixed now |
szaimen
requested review from
a team,
Pytal,
jancborchardt,
nfebe and
susnux
and removed request for
a team
|
Signed-off-by: Julian-Samuel Gebühr <[email protected]> Co-Authored-By: Simon L. <[email protected]> Co-Authored-By: Raimund Schlüßler <[email protected]>
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
Good to go from my side:
|
Thanks for doing all the real work, I very much appreciate it! |
|
/backport to stable7 |
|
Not backported due to the dependency on Nextcloud 27. |
|
@max-nextcloud we can add a fallback on the css vars on stable7 so it will work on all versions. (If there is a need for this) |
|
@susnux I was thinking the same but then decided to add the fallback inside text: nextcloud/text@c564511 . Pretty happy with that as it will also be easy to backport whereas using the NoteCard component would have required more changes. |
8 participants
This is a proposal for #4020 and linked to nextcloud/server#37953
I am net in any way experienced with this, so feel free to point out any errors. I am also not set on the colors, it's just what felt kinda right (but again, I am not a frontend dev)