[stable7] Add info NoteCard #4228
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julian-Samuel Gebühr <[email protected]> Co-Authored-By: Simon L. <[email protected]> Co-Authored-By: Raimund Schlüßler <[email protected]>
Contributor
|
This would probably allow us to make use of the note card in text in order to fix the color of info boxes to not depend on the theme color (nextcloud/text#4161). All versions of text that we'd want to backport the fix to use at least Nextcloud vue 7. |
Contributor
|
@max-nextcloud you know this needs 27? nextcloud/server#38205 |
Contributor
|
@szaimen ahh... good point. That's a pitty. How should we deal with that... only have it in 8.0 and then only use 8.0 in apps that only ship for 27+ ? |
Contributor
|
I think vue 8.0 is planned to release for nextcliud 28 and higher only so if we dont backport this change here we should be safe? |
Contributor
|
@szaimen ok. Makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #4063