Adjust header elements #710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
bug
jancborchardt
approved these changes
Nov 7, 2019
Contributor
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Makes more sense semantically and size-wize for the title as well. :) 👍
skjnldsv
requested changes
Nov 7, 2019
Contributor
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
See https://github.com/nextcloud/nextcloud-vue/blob/2b91823756b90ab251405fc8d8094bcf8be3f633/src/components/AppSidebar/AppSidebar.vue#L528
https://github.com/nextcloud/nextcloud-vue/blob/2b91823756b90ab251405fc8d8094bcf8be3f633/src/components/AppSidebar/AppSidebar.vue#L538
skjnldsv
added
2. developing
Contributor
|
/backport to stable0-12 |
nickvergessen
force-pushed
the
bugfix/noid/adjust-header-elements
branch
from
2b91823 to
c168b27
Compare
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
bugfix/noid/adjust-header-elements
branch
from
c168b27 to
c51d4bc
Compare
skjnldsv
added
3. to review
skjnldsv
reviewed
Nov 9, 2019
skjnldsv
reviewed
Nov 9, 2019
Contributor
|
Btw @georgehrke is this something which then needs to be changed for the component which Calendar uses, or is it just the same? |
skjnldsv
added
2. developing
Signed-off-by: Joas Schilling <[email protected]>
skjnldsv
approved these changes
Nov 22, 2019
|
backport to stable0-12 in #734 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @jancborchardt as discussed