Skip to content

Adjust header elements #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 2 commits into from
Nov 22, 2019
Merged

Adjust header elements #710

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c51d4bc
Adjust header elements
nickvergessen Nov 7, 2019
cdd4f19
Adjust CSS selector for the h2 aswell
nickvergessen Nov 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/components/AppSidebar/AppSidebar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,18 +111,18 @@
class="app-sidebar-header__star" @click.prevent="toggleStarred" />

<!-- main title -->
<h3 v-if="!titleEditable" class="app-sidebar-header__title">
<h2 v-if="!titleEditable" class="app-sidebar-header__title">
{{ title }}
</h3>
</h2>

<input v-if="titleEditable" v-focus class="app-sidebar-header__title-input"
type="text" :placeholder="titlePlaceholder" :value="title"
@input="onTitleInput">

<!-- secondary title -->
<h4 v-if="subtitle.trim() !== ''" class="app-sidebar-header__subtitle">
<p v-if="subtitle.trim() !== ''" class="app-sidebar-header__subtitle">
{{ subtitle }}
</h4>
</p>

<!-- header main menu -->
<Actions v-if="$slots['secondary-actions']" class="app-sidebar-header__menu">
Expand Down Expand Up @@ -517,16 +517,16 @@ $desc-height: 46px;
}
}
// titles
h3, h4 {
.app-sidebar-header__title,
.app-sidebar-header__subtitle {
width: 100%;
white-space: nowrap;
text-overflow: ellipsis;
overflow: hidden;
margin: 0;
}
// main title
h3 {
font-size: 16px;
.app-sidebar-header__title {
padding: 0;
}
input.app-sidebar-header__title-input {
Expand All @@ -535,7 +535,7 @@ $desc-height: 46px;
}

// subtitle
h4 {
.app-sidebar-header__subtitle {
font-size: 14px;
padding: 0;
opacity: $opacity_normal;
Expand Down