Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Jul 9, 2025

☑️ Resolves

Allows to programmatically set the obfuscation state of the password.
This is useful e.g. to hide the password in some cases, like submitting the login form.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@susnux susnux requested review from ShGKme, kesselb and skjnldsv July 9, 2025 18:54
@susnux susnux added enhancement New feature or request 3. to review Waiting for reviews feature: input-field Covering the InputField, TextField, ... labels Jul 9, 2025
@susnux susnux closed this Jul 9, 2025
@susnux susnux deleted the feat/password-field-obfuscated branch July 9, 2025 18:54
@susnux susnux restored the feat/password-field-obfuscated branch July 9, 2025 18:54
@susnux susnux reopened this Jul 9, 2025
@susnux
Copy link
Contributor Author

susnux commented Jul 9, 2025

/backport to stable8

@susnux susnux force-pushed the feat/password-field-obfuscated branch from 987eefa to d4fbbd4 Compare July 9, 2025 19:17
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for picking it up 🙏

Using "v-model:obfuscated" is much nicer than modifying the state directly. ;)

Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Make sense to put it in changelog notes?

@susnux
Copy link
Contributor Author

susnux commented Jul 10, 2025

obfuscated ( ❤️ ) vs visible ( 🚀 ) for the property name?

@susnux susnux changed the title feat(NcPasswordField): allow to set obfuscation state feat(NcPasswordField): allow to set visibility state Jul 14, 2025
@susnux susnux force-pushed the feat/password-field-obfuscated branch from d4fbbd4 to 531603b Compare July 14, 2025 11:18
@susnux
Copy link
Contributor Author

susnux commented Jul 14, 2025

Lets go with visible, even if I think obfuscated is also a good name, its better to stick with boolean values that default to false - in this case it would be non-obfuscated or we inverse it and just use visible.

@susnux susnux merged commit 32682e9 into main Jul 14, 2025
25 checks passed
@susnux susnux deleted the feat/password-field-obfuscated branch July 14, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request feature: input-field Covering the InputField, TextField, ...

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants