-
Notifications
You must be signed in to change notification settings - Fork 95
feat(NcPasswordField): allow to set visibility state #7135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/backport to stable8 |
987eefa to
d4fbbd4
Compare
kesselb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for picking it up 🙏
Using "v-model:obfuscated" is much nicer than modifying the state directly. ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Make sense to put it in changelog notes?
|
|
Signed-off-by: Ferdinand Thiessen <[email protected]>
d4fbbd4 to
531603b
Compare
|
Lets go with visible, even if I think |
☑️ Resolves
Allows to programmatically set the obfuscation state of the password.
This is useful e.g. to hide the password in some cases, like submitting the login form.
🏁 Checklist
stable8for maintained Vue 2 version or not applicable