feat(login): hide password on form submit #53869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
reviewed
Jul 8, 2025
| this.$emit('update:username', this.user) | ||
| }, | ||
| submit(event) { | ||
| this.$refs.password.$data.isPasswordHidden = true |
Contributor
There was a problem hiding this comment.
Using private internal state ($data) is very likely to break - or will even break with next version.
Instead the NcPasswordField probably should expose a setHidden(boolean) method.
Merged
kesselb
added
2. developing
kesselb
force-pushed
the
bug/53856/hide-password-on-submit
branch
from
b7211f1 to
dd2d3e4
Compare
kesselb
added
3. to review
Contributor
Author
|
Updated to use nextcloud-libraries/nextcloud-vue#7135 🥳 |
skjnldsv
approved these changes
Oct 7, 2025
provokateurin
approved these changes
Oct 7, 2025
Member
|
/compile rebase-amend |
nextcloud-command
force-pushed
the
bug/53856/hide-password-on-submit
branch
from
dd2d3e4 to
e0164e4
Compare
Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb
force-pushed
the
bug/53856/hide-password-on-submit
branch
from
e0164e4 to
ec1ea32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While edgy, it also sounds reasonable to mask the password again when pressing the login button.
I’m curious if that way of altering the state of a component will make it through the code review, but we will see about it. Otherwise, I think we first need a change for PasswordField to pass hidePassword as a prop?
Checklist