Use babel env usage & corejs@3 #749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
requested review from
ChristophWurst,
georgehrke,
juliusknorr,
korelstar and
raimund-schluessler
georgehrke
reviewed
Nov 27, 2019
skjnldsv
added
3. to review
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
This was referenced Nov 27, 2019
Closed
georgehrke
approved these changes
Nov 27, 2019
Contributor
georgehrke
left a comment
georgehrke
left a comment
There was a problem hiding this comment.
This fixes the privacy app-related issues i had this morning.
Module not found: Error: Can't resolve '@babel/runtime/helpers/asyncToGenerator' in '/Users/georgehrke/Development/Projects/Nextcloud/apps/privacy/node_modules/@nextcloud/vue/dist/Components' is gone.
juliusknorr
approved these changes
Nov 27, 2019
Contributor
|
Works great, thanks. nextcloud/tasks#688 is in now. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #692
Fixes #691
Tested on guests with this branch
