Skip to content

Update app to fit 18 new Sharing sidebar #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 3 commits into from
Nov 28, 2019
Merged

Update app to fit 18 new Sharing sidebar #153

skjnldsv merged 3 commits into from
Nov 28, 2019

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Aug 14, 2019 •
edited by rullzer
Loading

@skjnldsv skjnldsv added enhancement New feature or request javascript Javascript related ticket 2. developing Work in progress high High priority labels Aug 14, 2019
@skjnldsv skjnldsv self-assigned this Aug 14, 2019
@skjnldsv skjnldsv mentioned this pull request Aug 15, 2019
Merged
25 tasks
skjnldsv
skjnldsv commented Oct 6, 2019
View reviewed changes
skjnldsv
skjnldsv commented Oct 6, 2019
View reviewed changes
skjnldsv
skjnldsv commented Oct 6, 2019
View reviewed changes
skjnldsv
skjnldsv commented Oct 6, 2019
View reviewed changes
@skjnldsv skjnldsv force-pushed the comply-to-new-sidebar-and-use-axios branch 2 times, most recently from 58f93e8 to ed3fb3a Compare October 7, 2019 08:07
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 9, 2019
@skjnldsv skjnldsv mentioned this pull request Oct 29, 2019
Closed
14 tasks
ChristophWurst
ChristophWurst approved these changes Nov 19, 2019
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested & works (with my fixes)

@ChristophWurst ChristophWurst force-pushed the comply-to-new-sidebar-and-use-axios branch 3 times, most recently from cd0b14a to 5164bc0 Compare November 19, 2019 16:00
@ChristophWurst
Copy link
Member

ChristophWurst commented Nov 19, 2019

@skjnldsv merge

ChristophWurst
ChristophWurst reviewed Nov 19, 2019
View reviewed changes
This was referenced Nov 19, 2019
Merged
Merged
@rullzer
Copy link
Member

rullzer commented Nov 27, 2019

Rebase time!

@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 27, 2019

@rullzer review time too :p

rullzer
rullzer approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and seems to work.
Good to go once the rebase is in for the password policy IMO

@skjnldsv skjnldsv force-pushed the comply-to-new-sidebar-and-use-axios branch from 5164bc0 to b4c8732 Compare November 27, 2019 11:26
@skjnldsv
Update app to fit 18 new Sharing sidebar
a3be0db 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>

Use global eslint config and @nextcloud/packages

Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>

Drone fix

Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: Christoph Wurst <[email protected]>
@skjnldsv skjnldsv force-pushed the comply-to-new-sidebar-and-use-axios branch from b4c8732 to a3be0db Compare November 27, 2019 11:27
@skjnldsv
Migrate to @nextcloud/vue
b75d6d0 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 27, 2019

Rebased please advise

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish 3. to review Waiting for reviews 2. developing Work in progress and removed 3. to review Waiting for reviews 4. to release Ready to be released and/or waiting for tests to finish labels Nov 27, 2019
@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 27, 2019 •
edited
Loading

Needs nextcloud-libraries/nextcloud-vue#692 nextcloud-libraries/nextcloud-vue#749

@skjnldsv skjnldsv force-pushed the comply-to-new-sidebar-and-use-axios branch from 534f056 to beeb82f Compare November 27, 2019 11:59
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Nov 27, 2019
@skjnldsv skjnldsv force-pushed the comply-to-new-sidebar-and-use-axios branch from beeb82f to bd5ebe7 Compare November 27, 2019 15:23
@skjnldsv skjnldsv added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Nov 27, 2019
@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 27, 2019

@juliushaertl @ChristophWurst

  • Type: Exception
  • Code: 0
  • Message: Class 'OCP\Security\Events\GenerateSecurePasswordEvent' not found
  • File: /var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php
  • Line: 107

Still needs a bit of love?

@rullzer
Copy link
Member

rullzer commented Nov 28, 2019

@skjnldsv did you update your server version to master?
Because it seems to work here.

@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 28, 2019

@rullzer ah, maybe I did not!
LGTM then :)

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Nov 28, 2019
@skjnldsv skjnldsv merged commit b21d65b into master Nov 28, 2019
@skjnldsv skjnldsv deleted the comply-to-new-sidebar-and-use-axios branch November 28, 2019 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@rullzer rullzer rullzer approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@skjnldsv skjnldsv

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request high High priority javascript Javascript related ticket

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@skjnldsv @ChristophWurst @rullzer @juliusknorr