Skip to content

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Mar 20, 2025

Backport of #1931

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from artonge, hamza221 and susnux March 20, 2025 16:10
@backportbot backportbot bot added this to the Nextcloud 30.0.9 milestone Mar 20, 2025
@hamza221 hamza221 force-pushed the backport/1931/stable30 branch from a380839 to 333e888 Compare March 20, 2025 16:15
@hamza221 hamza221 marked this pull request as ready for review March 20, 2025 16:16
@codecov
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 30.85%. Comparing base (587f01e) to head (7ba7f24).

Files with missing lines Patch % Lines
src/views/ActivityAppFeed.vue 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           stable30    #1933      +/-   ##
============================================
- Coverage     30.89%   30.85%   -0.04%     
============================================
  Files            43       43              
  Lines          1615     1617       +2     
  Branches        110      110              
============================================
  Hits            499      499              
- Misses         1090     1092       +2     
  Partials         26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hamza221 hamza221 enabled auto-merge March 20, 2025 16:18
@cypress
Copy link

cypress bot commented Mar 20, 2025

Activity    Run #2431

Run Properties:  status check failed Failed #2431  •  git commit d58fcca589: [stable30] fix: disable loading when there are no more activities to load
Project Activity
Branch Review backport/1931/stable30
Run status status check failed Failed #2431
Run duration 04m 06s
Commit git commit d58fcca589: [stable30] fix: disable loading when there are no more activities to load
Committer backportbot[bot]
View all properties for this run ↗︎

Test results
Tests that failed  Failures 3
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 7
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/sidebar.cy.ts • 3 failed tests • Run E2E

View Output

Test Artifacts
Check activity listing in the sidebar > Has share activity Test Replay Screenshots
Check activity listing in the sidebar > Has tag activity Test Replay Screenshots
Check activity listing in the sidebar > Has comment activity Test Replay Screenshots

@miaulalala miaulalala force-pushed the backport/1931/stable30 branch from 333e888 to 544f359 Compare March 24, 2025 08:49
@miaulalala miaulalala disabled auto-merge March 24, 2025 10:43
@hamza221 hamza221 force-pushed the backport/1931/stable30 branch from 544f359 to cbb6720 Compare March 25, 2025 10:31
@Altahrim Altahrim mentioned this pull request Apr 3, 2025
5 tasks
@AndyScherzinger AndyScherzinger force-pushed the backport/1931/stable30 branch from cbb6720 to 7ba7f24 Compare April 3, 2025 13:12
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just breaks combined activities: #1959

@nickvergessen nickvergessen deleted the backport/1931/stable30 branch April 3, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants