-
Notifications
You must be signed in to change notification settings - Fork 68
[stable30] fix: disable loading when there are no more activities to load #1933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a380839 to
333e888
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stable30 #1933 +/- ##
============================================
- Coverage 30.89% 30.85% -0.04%
============================================
Files 43 43
Lines 1615 1617 +2
Branches 110 110
============================================
Hits 499 499
- Misses 1090 1092 +2
Partials 26 26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Activity
|
||||||||||||||||||||||||||||
| Project |
Activity
|
| Branch Review |
backport/1931/stable30
|
| Run status |
|
| Run duration | 04m 06s |
| Commit |
|
| Committer | backportbot[bot] |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
3
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
7
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/sidebar.cy.ts • 3 failed tests • Run E2E
333e888 to
544f359
Compare
544f359 to
cbb6720
Compare
Signed-off-by: Hamza Mahjoubi <[email protected]>
cbb6720 to
7ba7f24
Compare
nickvergessen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just breaks combined activities: #1959
Backport of #1931
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.