Skip to content

Conversation

@nickvergessen
Copy link
Member

This reverts commit 8fedeb9.

Without this pagination works totally fine. Otherwise pagination breaks when there was at least 1 grouped activity: #1931 (comment)

Steps to reproduce

  • Do some activity that you will remember afterwards
  • Create a folder
  • Upload 100 screenshots
  • Go to activity app
  • Try to scroll down until you can see the activity from step 1

@codecov
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 30.89%. Comparing base (183fbed) to head (a600f44).
Report is 2 commits behind head on stable31.

Files with missing lines Patch % Lines
src/views/ActivityAppFeed.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           stable31    #1959      +/-   ##
============================================
+ Coverage     30.85%   30.89%   +0.03%     
============================================
  Files            43       43              
  Lines          1617     1615       -2     
  Branches        110      110              
============================================
  Hits            499      499              
+ Misses         1092     1090       -2     
  Partials         26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nickvergessen nickvergessen merged commit 4cca650 into stable31 Apr 3, 2025
48 of 54 checks passed
@nickvergessen nickvergessen deleted the revert-1934 branch April 3, 2025 14:06
@Altahrim Altahrim mentioned this pull request Apr 3, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants