Skip to content

Conversation

@artonge
Copy link
Collaborator

@artonge artonge commented May 26, 2025

type is deprecated in v8 and removed in v9, so this makes Vue 3 migration easier by already using the new style.

Inspired from nextcloud/firstrunwizard#1604

@artonge artonge requested a review from susnux May 26, 2025 09:56
@artonge artonge self-assigned this May 26, 2025
@codecov
Copy link

codecov bot commented May 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.14%. Comparing base (c3e10aa) to head (c24c215).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2034   +/-   ##
=======================================
  Coverage   31.14%   31.14%           
=======================================
  Files          43       43           
  Lines        1583     1583           
  Branches      110      110           
=======================================
  Hits          493      493           
  Misses       1064     1064           
  Partials       26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cypress
Copy link

cypress bot commented May 26, 2025

Activity    Run #2604

Run Properties:  status check passed Passed #2604  •  git commit 6cec14d7b7: refactor: adjust nextcloud-vue props to latest version
Project Activity
Branch Review artonge/refactor/adjust-vue-props
Run status status check passed Passed #2604
Run duration 02m 14s
Commit git commit 6cec14d7b7: refactor: adjust nextcloud-vue props to latest version
Committer Louis
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 10
View all changes introduced in this branch ↗︎

@artonge artonge force-pushed the artonge/refactor/adjust-vue-props branch from 33056f7 to be3b7fb Compare May 26, 2025 14:15
@artonge
Copy link
Collaborator Author

artonge commented May 26, 2025

/compile amend /

Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@nextcloud-command nextcloud-command force-pushed the artonge/refactor/adjust-vue-props branch from be3b7fb to c24c215 Compare May 26, 2025 14:16
@artonge artonge merged commit 915af14 into master May 26, 2025
53 of 54 checks passed
@artonge artonge deleted the artonge/refactor/adjust-vue-props branch May 26, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants