Skip to content

Conversation

@artonge
Copy link
Collaborator

@artonge artonge commented May 26, 2025

⚠️ I would fancy a second opinion on the instantiation of the sidebar tab: 4ccae82

Inspired by nextcloud/firstrunwizard#1605

Chores

  • Update dependencies for vue3
  • Run npm lint:fix and fix reported warnings
  • Add unconventional commit workflow

Fixes

  • Fix usage of NcCheckboxRadioSwitch
  • Expose t in components
  • How SidebarTab is instantiated
  • Set dev mode for npm watch and dev

Refactors

  • Remove usage of vue-frag
  • Update usage of vue, vue-router and vuex

Need

@artonge artonge changed the base branch from master to artonge/chore/vue3 May 26, 2025 11:12
@artonge artonge self-assigned this May 26, 2025
@codecov
Copy link

codecov bot commented May 26, 2025

Codecov Report

Attention: Patch coverage is 16.53543% with 106 lines in your changes missing coverage. Please review.

Project coverage is 37.69%. Comparing base (d3dc63b) to head (98f19a8).
Report is 24 commits behind head on master.

Files with missing lines Patch % Lines
src/sidebar.ts 0.00% 18 Missing ⚠️
src/store/settings-store.ts 0.00% 12 Missing ⚠️
src/components/ActivityGroup.vue 0.00% 10 Missing ⚠️
src/settings-admin.ts 9.09% 10 Missing ⚠️
src/settings-personal.ts 9.09% 10 Missing ⚠️
src/app.ts 0.00% 7 Missing ⚠️
src/views/ActivityAppNavigation.vue 0.00% 7 Missing ⚠️
src/views/AdminSettings.vue 0.00% 6 Missing ⚠️
src/views/DailySummary.vue 0.00% 6 Missing ⚠️
src/views/ActivityAppFeed.vue 0.00% 5 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2035      +/-   ##
==========================================
+ Coverage   31.14%   37.69%   +6.54%     
==========================================
  Files          43       43              
  Lines        1583     1682      +99     
  Branches      110      119       +9     
==========================================
+ Hits          493      634     +141     
+ Misses       1064     1047      -17     
+ Partials       26        1      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cypress
Copy link

cypress bot commented May 26, 2025

Activity    Run #2663

Run Properties:  status check passed Passed #2663  •  git commit ff9de506dc: feat: migrate to Vue 3
Project Activity
Branch Review artonge/chore/migrate_vue3
Run status status check passed Passed #2663
Run duration 02m 21s
Commit git commit ff9de506dc: feat: migrate to Vue 3
Committer Louis
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 10
View all changes introduced in this branch ↗︎

@artonge artonge force-pushed the artonge/chore/vue3 branch from bd08c12 to 5f81ebe Compare May 26, 2025 11:46
@artonge artonge force-pushed the artonge/chore/migrate_vue3 branch 2 times, most recently from 08e67f2 to ca71d1a Compare May 26, 2025 11:58
@artonge artonge marked this pull request as draft May 26, 2025 12:05
Base automatically changed from artonge/chore/vue3 to master May 26, 2025 13:48
@artonge artonge force-pushed the artonge/chore/migrate_vue3 branch 2 times, most recently from 35b4818 to 3ed6373 Compare June 2, 2025 15:22
@artonge artonge requested a review from susnux June 2, 2025 15:23
@artonge artonge marked this pull request as ready for review June 2, 2025 15:32
@artonge artonge force-pushed the artonge/chore/migrate_vue3 branch from 0523a45 to 6b86746 Compare June 2, 2025 16:53
@artonge
Copy link
Collaborator Author

artonge commented Jun 2, 2025

/compile /

@artonge artonge force-pushed the artonge/chore/migrate_vue3 branch from 4896f41 to 3d8fbbf Compare June 4, 2025 15:08
artonge and others added 6 commits June 4, 2025 17:09
This is needed is we removed the global exposition.

Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@artonge artonge force-pushed the artonge/chore/migrate_vue3 branch from 3d8fbbf to 98f19a8 Compare June 4, 2025 15:09
@artonge artonge merged commit 98cd5ed into master Jun 20, 2025
59 of 62 checks passed
@artonge artonge deleted the artonge/chore/migrate_vue3 branch June 20, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants