feat: migrate to Vue 3 #1605
Merged
feat: migrate to Vue 3 #1605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Tested and works - there is only a slight visual issue with a button but that is caused by library and not related to this PR. |
susnux
force-pushed
the
feat/migrate-to-vue3
branch
from
b89449f to
84dc9c8
Compare
Contributor
Author
|
/compile |
Contributor
Author
|
Reuse currently fails because of: nextcloud-libraries/nextcloud-vite-config#606 |
skjnldsv
reviewed
May 7, 2025
Comment on lines
+14
to
+16
| :has-next | ||
| :has-previous | ||
| :set-return-focus |
Member
There was a problem hiding this comment.
Ooooh! A bit weird, but also cool! 😁
Contributor
Author
There was a problem hiding this comment.
Yeah something I needed time to get used to. Like some other things that are new and sometimes I do not like but its how it is and the way Vue evolves so as I cannot change it I have to get used to it^^
skjnldsv
approved these changes
May 7, 2025
- Adjust dependencies - Adjust how Vue app is created - Fragment is no longer needed as Vue 3 supports multi-root elements - `v-model` vs old legacy `.sync` Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
susnux
force-pushed
the
feat/migrate-to-vue3
branch
from
8832093 to
759294b
Compare
Contributor
Author
|
Updated vite config should be fixed now |
Member
|
Congrats!!!! |
Collaborator
|
🎉🎉🎉🎉🎉 |
2 tasks
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v-modelvs old legacy.sync