fix(FilesHooks): Catch all exceptions when looking up unrelated users #2052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will catch "Undefined array key" exceptions from above `$cachedPath[$userId]`. Fix: nextcloud/groupfolders#3680 Signed-off-by: Louis Chemineau <[email protected]>
Collaborator
Author
|
/backport to stable31 |
Collaborator
Author
|
/backport to stable30 |
Collaborator
Author
|
/backport to stable29 |
Activity
|
||||||||||||||||||||||||||||
| Project |
Activity
|
| Branch Review |
artonge/fix/fileshook_try_catch
|
| Run status |
|
| Run duration | 02m 17s |
| Commit |
|
| Committer | Louis |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
10
|
| View all changes introduced in this branch ↗︎ | |
Contributor
|
/backport! to stable28 |
Member
|
should we log something ? |
ArtificialOwl
approved these changes
Jun 4, 2025
Collaborator
Author
Not sure, as at that point, we do not know why the user was is not in Best would have been to add an Considering that I don't know enough to change the code further, and that the initial intention of the code was probably to catch all exceptions, I would stick with the current solution. |
This was referenced Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will catch "Undefined array key" exceptions from above
$cachedPath[$userId].Fix: nextcloud/groupfolders#3680