Skip to content

fix(FilesHooks): Catch all exceptions when looking up unrelated users #2052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
artonge merged 1 commit into from
Jun 10, 2025
Merged

fix(FilesHooks): Catch all exceptions when looking up unrelated users #2052

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(FilesHooks): Catch all exceptions when looking up unrelated users 
This will catch "Undefined array key" exceptions from above `$cachedPath[$userId]`.

Fix: nextcloud/groupfolders#3680
Signed-off-by: Louis Chemineau <[email protected]>
  • Loading branch information
@artonge
artonge committed Jun 4, 2025
commit d61c433072bb383cc748dcf5abb28e76f16a3163
2 changes: 1 addition & 1 deletion lib/FilesHooks.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1398,7 +1398,7 @@ private function getUnrelatedUsers(int $fileId, array $cachedMounts): array {
if ($node->isReadable()) {
continue; // overkill ? as rootFolder->get() would throw an exception if file is not available
}
} catch (\Exception $e) {
} catch (\Throwable $e) {
}

$filteredUsers[] = $userId;
Expand Down
Loading