[stable31] fix: catch NotFoundException when user is resharer #2217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the file source path and user path for resharing users doesn't match, catch the exception and don't generate a notification. Signed-off-by: Anna Larch <[email protected]>
Activity
|
||||||||||||||||||||||||||||
| Project |
Activity
|
| Branch Review |
fix/2148/catch-path-exception
|
| Run status |
|
| Run duration | 02m 14s |
| Commit |
|
| Committer | Anna |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
10
|
| View all changes introduced in this branch ↗︎ | |
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Would a test be possible? 🙊
14 tasks
skjnldsv
approved these changes
Nov 10, 2025
Member
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
Btw, it's still feels weirf that we cannot compute the path properly. The end user should still get the notification, no ?
Collaborator
Author
We don't notify for 32+ either, it just fails more gracefully. I guess we could add a check on the file owner and send them a notification instead, but then we'll have to backport from master. |
miaulalala
force-pushed
the
fix/2148/catch-path-exception
branch
from
db41827 to
521d549
Compare
Signed-off-by: Anna Larch <[email protected]>
miaulalala
force-pushed
the
fix/2148/catch-path-exception
branch
from
521d549 to
ff88d8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the file source path and user path for resharing users doesn't match, catch the exception and don't generate a notification instead.
Issue might be from #2103, but the exception is also not bubbling up for 32+, so something else must have changed as well.
Fixes #2148