getUsersFavoritingObject is moved to the manager #506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <[email protected]>
Member
Author
|
/backport to stable20 |
icewind1991
approved these changes
Oct 7, 2020
Signed-off-by: Joas Schilling <[email protected]>
ChristophWurst
approved these changes
Oct 8, 2020
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Though I would say if you expect the TagManager then have that injected in the constructor
delete-merged-branch
bot
deleted the
bugfix/noid/getUsersFavoritingObject-moved-to-manager
branch
Member
Author
|
Well let's just add it to the interface once the situation cleared up and we know it's working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #499
Ref https://sentry.io/organizations/nextcloud-gmbh/issues/1927876255