Skip to content

Conversation

@sharidas
Copy link

@sharidas sharidas commented Oct 5, 2020

When user tries to delete the files in a public
link, the files don't get deleted. The tagManager
gets null and there was no check to handle this.
Added check for this.

Signed-off-by: Sujith Haridasan [email protected]

When user tries to delete the files in a public
link, the files don't get deleted. The tagManager
gets null and there was no check to handle this.
Added check for this.

Signed-off-by: Sujith Haridasan <[email protected]>
@sharidas sharidas self-assigned this Oct 5, 2020
@sharidas sharidas linked an issue Oct 5, 2020 that may be closed by this pull request
@sharidas
Copy link
Author

sharidas commented Oct 5, 2020

Summary

When user tries to delete the files inside a public link the files are not getting deleted. The permission set for the public link in this case is Allow upload and editing.

Description

The tagManager is set to null in the stack trace. Hence I have tried to provide an array with nulls if the tagManager is null, which aligns with the function signature( function is getFileChangeActivitySettings).

Steps done for testing

  1. Create a public link with folder. Add some files to this folder.
  2. Give the permission to this link as Allow upload and editing
  3. Open this link in an incognito mode
  4. Delete the file from this link.
  5. No error found in the logs or in the networking tab.
  6. The file was found in the trash.

@nickvergessen
Copy link
Member

See #506

@nickvergessen
Copy link
Member

Thanks for your PR anyway! 😎
Always cool to see PRs from people with OC t-shirts on their avatars 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Call to a member function getUsersFavoritingObject() on null

3 participants