Use new PHPUnit CI setup from nextcloud/.github #777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-nc
force-pushed
the
enh/use-new-phpunit-setup
branch
from
0462843 to
4c27e7f
Compare
Contributor
Author
|
Testing nextcloud/.github#53 |
| - name: PHPUnit integration | ||
| # Only run if phpunit integration config file exists | ||
| if: steps.check_integration.outputs.files_exists == 'true' | ||
| working-directory: apps/${{ env.APP_NAME }} |
Member
There was a problem hiding this comment.
biggest difference is the location.
This used to get called from:
- name: PHPUnit
working-directory: apps/${{ env.APP_NAME }}/tests
run: ../vendor/bin/phpunit -c phpunit.xml
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Member
There was a problem hiding this comment.
Not sure what I tested, but now I can reproduce it with this change.
activity/tests$ ../vendor/bin/phpunit -c phpunit.xml
PHPUnit 9.5.20 #StandWithUkraine
Runtime: PHP 7.4.28
Configuration: phpunit.xml
Warning: No code coverage driver available
Warning: Your XML configuration validates against a deprecated schema.
Suggestion: Migrate your XML configuration using "--migrate-configuration"!
............................................................... 63 / 263 ( 23%)
............................................................... 126 / 263 ( 47%)
....................................................WWWW......W 189 / 263 ( 71%)
WWWW........................................................... 252 / 263 ( 95%)
......WWWWW 263 / 263 (100%)
Time: 00:05.714, Memory: 42.50 MB
activity$ ./vendor/bin/phpunit -c tests/phpunit.xml
PHPUnit 9.5.20 #StandWithUkraine
Runtime: PHP 7.4.28
Configuration: tests/phpunit.xml
Warning: No code coverage driver available
Warning: Your XML configuration validates against a deprecated schema.
Suggestion: Migrate your XML configuration using "--migrate-configuration"!
............................................................... 63 / 263 ( 23%)
............................................................... 126 / 263 ( 47%)
.........E..........................................WWWW......W 189 / 263 ( 71%)
WWWW........................................................... 252 / 263 ( 95%)
......WWWWW 263 / 263 (100%)
Time: 00:05.679, Memory: 40.50 MB
There was 1 error:
1) OCA\Activity\Tests\Controller\ActivitiesControllerTest::testShowList
Exception: The requested uri() cannot be processed by the script './vendor/bin/phpunit')
Member
There was a problem hiding this comment.
The actual problem is here:
https://github.com/nextcloud/server/blob/eede608c0e9cd313bc672df1f0e37aca2a0ef2ad/lib/private/legacy/OC_App.php#L632
var_dump('$request->getScriptName()', $request->getScriptName());
var_dump('$script', $script);
var_dump('$topFolder', $topFolder);
string(25) "$request->getScriptName()"
string(20) "./vendor/bin/phpunit"
string(7) "$script"
string(19) "/vendor/bin/phpunit"
string(10) "$topFolder"
string(0) ""
vs.
string(25) "$request->getScriptName()"
string(21) "../vendor/bin/phpunit"
string(7) "$script"
string(20) "./vendor/bin/phpunit"
string(10) "$topFolder"
string(1) "."
so in the first case
https://github.com/nextcloud/server/blob/eede608c0e9cd313bc672df1f0e37aca2a0ef2ad/lib/private/legacy/OC_App.php#L635-L636
is entered and then throws, while in the second case we continue with $topFolder = '.' ....
I guess the function needs some special handling for CLI cases or at least should not throw....
Contributor
Author
|
/rebase |
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
nextcloud-command
force-pushed
the
enh/use-new-phpunit-setup
branch
from
ac4fed2 to
57c01a2
Compare
nickvergessen
approved these changes
Jun 13, 2022
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Adjusted required job list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Côme Chilliet [email protected]